From 3f499429d70539dc188054eabf17c4075fd90ab5 Mon Sep 17 00:00:00 2001 From: drendog Date: Wed, 21 Aug 2024 00:52:30 +0200 Subject: [PATCH] refactor: minor clippy warns --- src/windowing/builder.rs | 1 + src/windowing/mod.rs | 6 +++--- src/windowing/state/builder.rs | 2 +- src/windowing/state/mod.rs | 1 + 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/windowing/builder.rs b/src/windowing/builder.rs index 8d7d104..7f3fb98 100644 --- a/src/windowing/builder.rs +++ b/src/windowing/builder.rs @@ -83,6 +83,7 @@ impl WindowingSystemBuilder { self } + #[allow(clippy::missing_errors_doc)] pub fn build(&mut self) -> Result { match self.config.component_definition { Some(_) => WindowingSystem::new(&mut self.config), diff --git a/src/windowing/mod.rs b/src/windowing/mod.rs index 5938ebf..c22c234 100644 --- a/src/windowing/mod.rs +++ b/src/windowing/mod.rs @@ -51,7 +51,7 @@ impl WindowingSystem { &layer_shell, &event_queue.handle(), config, - )?; + ); let pointer = Rc::new(seat.get_pointer(&event_queue.handle(), ())); @@ -104,7 +104,7 @@ impl WindowingSystem { layer_shell: &ZwlrLayerShellV1, queue_handle: &QueueHandle, config: &config::WindowConfig, - ) -> Result<(Rc, Rc)> { + ) -> (Rc, Rc) { let surface = Rc::new(compositor.create_surface(queue_handle, ())); let layer_surface = Rc::new(layer_shell.get_layer_surface( &surface, @@ -117,7 +117,7 @@ impl WindowingSystem { Self::configure_layer_surface(&layer_surface, &surface, config); - Ok((surface, layer_surface)) + (surface, layer_surface) } fn configure_layer_surface( diff --git a/src/windowing/state/builder.rs b/src/windowing/state/builder.rs index 943725f..a8b2505 100644 --- a/src/windowing/state/builder.rs +++ b/src/windowing/state/builder.rs @@ -23,7 +23,7 @@ pub struct WindowStateBuilder { impl WindowStateBuilder { pub fn new() -> Self { - Default::default() + Self::default() } pub fn surface(mut self, surface: Rc) -> Self { diff --git a/src/windowing/state/mod.rs b/src/windowing/state/mod.rs index a79596c..5f3a6f3 100644 --- a/src/windowing/state/mod.rs +++ b/src/windowing/state/mod.rs @@ -63,6 +63,7 @@ impl WindowState { self.size = new_size; } + #[allow(clippy::cast_possible_truncation)] pub fn set_current_pointer_position(&mut self, physical_x: f64, physical_y: f64) { let scale_factor = self.scale_factor; let logical_position = LogicalPosition::new(